-
Couldn't load subscription status.
- Fork 5
chore(ci): automate detection of last auto-rename commit #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b13b43d to
f0c8766
Compare
a31a804 to
65917f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your git-fu is very impressive. Thank you; I learnt a lot from this PR.
|
Thinking about this some more, I don't think it's necessary to find the geth commit as all we need is the latest renaming commit. I think the whole thing can be reduced to a single line: git rev-list --author "github-actions\[bot\]" --grep renam -n 1 origin/mainThen both scripts can be deleted. I haven't checked the exact line above as I'm on my phone, but the general idea is sound IMO. Using "renam" catches both "rename" and "renaming" in case somebody changes it in the future, but probably best to add a comment on that workflow stating that it MUST include it. |
|
That's great! Although I would keep the grep to the full |
fd517ab to
66e2357
Compare
Let's use "rename Go module" then as it's the shortest string that's specific to what we're looking for. |
Why this should be merged
No need to manually update the commit hash of the last auto rename commit.
How this works
It reverse searches the commit from the github bot author and matching the automated commit message.
How this was tested
CI passing